-
Notifications
You must be signed in to change notification settings - Fork 23
fix(package): update jest dependencies #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimenB do you have any ideas on why do we have extra space in the snapshots?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. It's a diff for jest 21. I'll see if I can isolate it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's this: jestjs/jest@7e2c206
/cc @pedrottimark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that PR fixed a difference (pardon the pun :) between options:
expand: trueoutput a one-space "gutter" between -/+/space and content so content aligned with labels (seecan expand diff 1below)expand: falsedid not, but now it does, so the snapshot will not change if you toggle the option (for a diff which has fewer lines than the context)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You guys are awesome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thymikee This change is from jestjs/jest#4520:
expand: falseoption made sure that strings end with newlineexpand: truedid not, and in this case it even trimmed the newline at end of expected and received strings!
Thanks @SimenB @pedrottimark we'll need to mark it as breaking change then.
8887043 to
9e1292e
Compare
@SimenB ping, we have a CI now 😉 thanks for reminding me about it
9e1292e to
6c50d6e
Compare
Breaking change: indentation of diff has changed
6c50d6e to
2bd28e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted the lockfile to update all deps within semver, and without also updating eslint-config-callstack-io we are hit by the babel-eslint bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, good move
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can update the eslint config in the followup PR though
I'm cool with next release to be a major, happy to see #20 as a part of it. I'll try to squeeze some time tomorrow or so to do some work (would also be cool to add more plugins by default, e.g. ReactTestComponent, not only ReactElement)
pedrottimark
commented
Jan 29, 2018
@pedrottimark that's a valid point. We don't have a release schedule, so I'm ok with waiting a bit for the new release. WDYT @SimenB?
It's annoying to see beta deps in my tree but there is no rush of course 🙂
I cannot reproduce the failing node 6 test locally 🙁. Is this travis and colors again?
Looks like Travis being color blind again 🤷♂️
Uh oh!
There was an error while loading. Please reload this page.
(mostly to not rely on beta releases)